feat: modernize Android build toolchain#271
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jokerttu
force-pushed
the
feat/modernize-android-build-toolchain
branch
from
a0e885a to
d81c539
Compare
- Convert the plugin's android/build.gradle + settings.gradle to Kotlin DSL (.kts).
- Plugin: apply KGP conditionally (only on AGP < 9).
- Replace deprecated `kotlinOptions {}` with `kotlin { compilerOptions {} }` in plugin and example.
- Raise Java/Kotlin target 11 → 17 (matches Flutter templates and Navigation SDK requirement).
- Bump example Gradle wrapper 8.13 → 8.14.3 and Kotlin (KGP) 2.1.0 → 2.3.20.
- Gate the ktfmt formatter behind `-Pktfmt` so it is never forced on consuming apps.
jokerttu
force-pushed
the
feat/modernize-android-build-toolchain
branch
from
d81c539 to
b8a72ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
android/build.gradle+settings.gradleto Kotlin DSL (.kts).kotlinOptions {}withkotlin { compilerOptions {} }in plugin and example.-Pktfmt(viamelos run format:android) so it is never forced onto apps that depend on this plugin.Pre-launch Checklist